CPLAT-4887: propTypes in Component2#317
Merged
rmconsole3-wf merged 25 commits into3.1.0-wipfrom Aug 2, 2019
Merged
Conversation
* master: Changelog entry for v2.4.4 over_react_2.4.4+dart2 Update base image to Dart2.4 Add dev_dep on build_resolvers. Remove coverage dep as it is currently unused. Upgrade to analyzer 0.36.x and build_web_compilers 2.x Changelog entry for v2.4.3 over_react_2.4.3+dart2 Run CI on the dev channel as well. Add more detailed warning message Fix another typo Fix typo Warn consumers if part directive is present, but no generations were found Update handler chain util tests. Reduce callback constant boilerplate Add explicit dynamic return types, use new typedef syntax Use local methods for better stack traces, add return type to fix lints Remove duplicated doc comments, which get inherited Remove CallbackUtil generic parameter, use covariant to add chainFromList typing
* 3.1.0-wip: merge master and revert pubspec Update comments Update comments Revert "Revert "Revert pubspec"" Revert "Revert pubspec" Revert pubspec Update pubspec Update copyright comments Update pubspec to see if CPLAT-4652 build passes Update pubspec Add pointer event callbacks to prop mixins Update formatting Remove componentFactory argument Update comments Update based on reviewer feedback Remove build_daemon Add tests Pull fragment from react.dart Add dependency to pubspec Add initial wrapper
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
* 3.1.0-wip: remove covariant adding component factory setter and updating test adding covariant to componentFactory using a field in UiProps instead of getter/setter re-add comment for getter add componentFactory setter to builder
kealjones-wk
force-pushed
the
CPLAT-4887-PropTypes
branch
from
23c5815 to
1ecf5ba
Compare
greglittlefield-wf
requested changes
Jul 23, 2019
lib/src/component_declaration/component_base/component_base_2.dart
Outdated
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Outdated
Show resolved
Hide resolved
…r_react into CPLAT-4887-PropTypes
greglittlefield-wf
requested changes
Aug 2, 2019
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Show resolved
Hide resolved
...ration/builder_integration_tests/component2/constant_required_accessor_integration_test.dart
Show resolved
Hide resolved
Contributor
|
+10, besides dependency override that should be removed |
greglittlefield-wf
approved these changes
Aug 2, 2019
Contributor
Author
|
+1 to gregs commits :| |
Contributor
Author
|
@Workiva/release-management-p |
Contributor
Author
|
how bout now? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Depends on Workiva/react-dart#192
Until @greglittlefield-wf's new adapter changes, so diff will be a little dirty until thats merged.
Motivation
Add propTypes compatibility to Component2 to include Typed
propsarguments.Changes
jsifyPropTypesimplementation to the component bridge.@requiredannotationsvalidateProps&validateRequiredPropsto throwUnsupportedErrorand addedmustCallSuperRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: