CPLAT-6477 Update Snippets for React 16#324
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
kealjones-wk
left a comment
There was a problem hiding this comment.
So more generally,
I feel that because dart2 will be out completely and dart1 will be gone, we should remove all dart1 and dart1 and 2 snippets and only have these new snippets.
Additionally we should update the snippet names to be the original ones we had so they are clean again since these are currently ridiculous.
instead of ord2CStless just orStless
so take all the names from "Trigger - Dart 1/2 Compatible" here: https://github.com/Workiva/over_react/tree/master/snippets#available-code-snippets
We should also update the README to reflect only these new ones
I had thought maybe we should have a Component1 and Component2 set but after discussing with @greglittlefield-wf we decided we should only have Component2 snippets
Co-Authored-By: Keal Jones <41018730+kealjones-wk@users.noreply.github.com>
|
@Workiva/release-management-p |
Motivation
The OverReact component snippets were still using
component,UiComponent, andAbstractComponent, andUiStatefulComponent. We need to update those references to use the new V2 versions.Changes
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
@aaronlademann-wf @kealjones-wk @sydneyjodon-wk @greglittlefield-wf
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: