Skip to content

CPLAT-6477 Update Snippets for React 16#324

Merged
rmconsole5-wk merged 6 commits into3.1.0-wipfrom
CPLAT-6477-update-snippets
Aug 6, 2019
Merged

CPLAT-6477 Update Snippets for React 16#324
rmconsole5-wk merged 6 commits into3.1.0-wipfrom
CPLAT-6477-update-snippets

Conversation

@joebingham-wk
Copy link
Contributor

@joebingham-wk joebingham-wk commented Jul 31, 2019

Motivation

The OverReact component snippets were still using component, UiComponent, and AbstractComponent, and UiStatefulComponent. We need to update those references to use the new V2 versions.

Changes

  • Update the Dart2 snippets to use the new React 16 componentry.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@aaronlademann-wf @kealjones-wk @sydneyjodon-wk @greglittlefield-wf

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
    • Use the XML files as snippets and ensure their output is correct.
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So more generally,
I feel that because dart2 will be out completely and dart1 will be gone, we should remove all dart1 and dart1 and 2 snippets and only have these new snippets.

Additionally we should update the snippet names to be the original ones we had so they are clean again since these are currently ridiculous.

instead of ord2CStless just orStless
so take all the names from "Trigger - Dart 1/2 Compatible" here: https://github.com/Workiva/over_react/tree/master/snippets#available-code-snippets

We should also update the README to reflect only these new ones

I had thought maybe we should have a Component1 and Component2 set but after discussing with @greglittlefield-wf we decided we should only have Component2 snippets

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Co-Authored-By: Keal Jones <41018730+kealjones-wk@users.noreply.github.com>
Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

Copy link
Contributor

@kealjones-wk kealjones-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@kealjones-wk
Copy link
Contributor

@Workiva/release-management-p

@rmconsole5-wk rmconsole5-wk merged commit e40749e into 3.1.0-wip Aug 6, 2019
@rmconsole5-wk rmconsole5-wk deleted the CPLAT-6477-update-snippets branch August 6, 2019 15:39
@aaronlademann-wf aaronlademann-wf added this to the 3.1.0 milestone Aug 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants