CPLAT-7367 Remove Implementation via the On Key Word#336
Merged
greglittlefield-wf merged 9 commits into3.1.0-wipfrom Sep 12, 2019
Merged
CPLAT-7367 Remove Implementation via the On Key Word#336greglittlefield-wf merged 9 commits into3.1.0-wipfrom
greglittlefield-wf merged 9 commits into3.1.0-wipfrom
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Co-Authored-By: Greg Littlefield <greg.littlefield@workiva.com>
…2275-regression-test-Component2
…rkiva/over_react into CPLAT-2275-regression-test-Component2
...t/component_declaration/builder_integration_tests/component2/component_integration_test.dart
Outdated
Show resolved
Hide resolved
...nt_declaration/builder_integration_tests/component2/stateful_component_integration_test.dart
Outdated
Show resolved
Hide resolved
Contributor
|
+10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Using the
onkeyword on_GeneratedUiComponentStubscauses issues with the inheritance of state. This is a known issue caused by dart-lang/sdk#38098.Changes
ontoimplementsand add a comment describing why.Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
@aaronlademann-wf @kealjones-wk @greglittlefield-wf @sydneyjodon-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: