Skip to content

CPLAT-7367 Remove Implementation via the On Key Word#336

Merged
greglittlefield-wf merged 9 commits into3.1.0-wipfrom
CPLAT-2275-regression-test-Component2
Sep 12, 2019
Merged

CPLAT-7367 Remove Implementation via the On Key Word#336
greglittlefield-wf merged 9 commits into3.1.0-wipfrom
CPLAT-2275-regression-test-Component2

Conversation

@joebingham-wk
Copy link
Contributor

Motivation

Using the on keyword on _GeneratedUiComponentStubs causes issues with the inheritance of state. This is a known issue caused by dart-lang/sdk#38098.

Changes

  • Change on to implements and add a comment describing why.

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@aaronlademann-wf @kealjones-wk @greglittlefield-wf @sydneyjodon-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@greglittlefield-wf
Copy link
Contributor

+10

@greglittlefield-wf greglittlefield-wf merged commit 7450724 into 3.1.0-wip Sep 12, 2019
@aaronlademann-wf aaronlademann-wf added this to the 3.1.0 milestone Oct 3, 2019
@greglittlefield-wf greglittlefield-wf deleted the CPLAT-2275-regression-test-Component2 branch February 24, 2020 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants