Skip to content

CPLAT-7561 Add missing DomProps and SvgProps fields#362

Merged
rmconsole5-wk merged 14 commits into3.1.0-wipfrom
CPLAT-7561-add-missing-domprops-svgprops
Oct 29, 2019
Merged

CPLAT-7561 Add missing DomProps and SvgProps fields#362
rmconsole5-wk merged 14 commits into3.1.0-wipfrom
CPLAT-7561-add-missing-domprops-svgprops

Conversation

@sydneyjodon-wk
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk commented Oct 9, 2019

Motivation

Many React DOM and SVG attributes are missing from over_react DomProps and SvgProps and need to be added.

Changes

Add missing DomProps and SvgProps field that are listed in the following:

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:
@kealjones-wk @aaronlademann-wf @greglittlefield-wf @joebingham-wk

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary2-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@sydneyjodon-wk sydneyjodon-wk changed the title Add missing DomProps and SvgProps fields CPLAT-7561 Add missing DomProps and SvgProps fields Oct 9, 2019
Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really, really good! That's a lot of attributes haha. There were a few I had questions about, but not too many!

@aaronlademann-wf aaronlademann-wf added this to the 3.1.0 milestone Oct 11, 2019
# Conflicts:
#	lib/src/component/prop_mixins.dart
#	lib/src/component/prop_mixins.over_react.g.dart
# Conflicts:
#	lib/src/component/prop_mixins.dart
#	lib/src/component/prop_mixins.over_react.g.dart
Copy link
Contributor

@joebingham-wk joebingham-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

Copy link
Contributor

@aaronlademann-wf aaronlademann-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@joebingham-wk
Copy link
Contributor

@Workiva/release-management-pp

@rmconsole5-wk rmconsole5-wk merged commit 4b1927c into 3.1.0-wip Oct 29, 2019
@rmconsole5-wk rmconsole5-wk deleted the CPLAT-7561-add-missing-domprops-svgprops branch October 29, 2019 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants