CPLAT-7561 Add missing DomProps and SvgProps fields#362
Merged
rmconsole5-wk merged 14 commits into3.1.0-wipfrom Oct 29, 2019
Merged
CPLAT-7561 Add missing DomProps and SvgProps fields#362rmconsole5-wk merged 14 commits into3.1.0-wipfrom
rmconsole5-wk merged 14 commits into3.1.0-wipfrom
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
This reverts commit 0466c5e.
8 tasks
Contributor
joebingham-wk
left a comment
There was a problem hiding this comment.
Looks really, really good! That's a lot of attributes haha. There were a few I had questions about, but not too many!
# Conflicts: # lib/src/component/prop_mixins.dart # lib/src/component/prop_mixins.over_react.g.dart
# Conflicts: # lib/src/component/prop_mixins.dart # lib/src/component/prop_mixins.over_react.g.dart
# Conflicts: # lib/src/component/prop_mixins.dart # lib/src/component/prop_mixins.over_react.g.dart
Contributor
|
@Workiva/release-management-pp |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Many React DOM and SVG attributes are missing from over_react DomProps and SvgProps and need to be added.
Changes
Add missing DomProps and SvgProps field that are listed in the following:
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
@kealjones-wk @aaronlademann-wf @greglittlefield-wf @joebingham-wk
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: