Skip to content

Boyscoutin: Replace deprecated ExpansionPanel with new Accordion from MaterialUi#619

Merged
rmconsole4-wk merged 1 commit intomasterfrom
todo-example-replace-expansionpanel
Aug 19, 2020
Merged

Boyscoutin: Replace deprecated ExpansionPanel with new Accordion from MaterialUi#619
rmconsole4-wk merged 1 commit intomasterfrom
todo-example-replace-expansionpanel

Conversation

@kealjones-wk
Copy link
Contributor

Motivation

Noticed lots of deprecation warnings around ExpansionPanel when running the todo example.

Changes

  • Replaced deprecated ExpansionPanel with the new Accordion component in ToDo Demo

Release Notes

  • Replaced MaterialUi's deprecated ExpansionPanel usage with the new Accordion component in ToDo Demo

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Client Platform member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@aaronlademann-wf
Copy link
Contributor

FYI @willdrach-wk

Copy link

@willdrach-wk willdrach-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Party on. I'll do the necessary changes in my branches once this is in.

@kealjones-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole4-wk rmconsole4-wk merged commit daff050 into master Aug 19, 2020
@rmconsole4-wk rmconsole4-wk deleted the todo-example-replace-expansionpanel branch August 19, 2020 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants