UIP-2260 Release over_react 1.9.1 (HOTFIX)#66
Merged
aaronlademann-wf merged 2 commits intomasterfrom May 3, 2017
Merged
Conversation
RavenNumber of Findings: 0 |
Codecov Report
@@ Coverage Diff @@
## master #66 +/- ##
==========================================
- Coverage 97.69% 97.69% -<.01%
==========================================
Files 28 28
Lines 1381 1380 -1
==========================================
- Hits 1349 1348 -1
Misses 32 32 |
Contributor
|
+1 |
|
+10 from Home
|
Contributor
|
QA +10
Merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ultimate problem:
Consumers of AbstractTransition (like
OverlayRenderer) that didn't callsuper.componentDidMountstopped working properly in over_react 1.9.0: transitions never completed.How it was fixed:
Remove
componentDidMountrequirement as a quick fix.Testing suggestions:
Pull in this version of over_react, and verify that overlay DOM gets cleaned up when overlays (e.g., web_skin_dart Alerts, Popovers, etc.) are transitioned out:
Potential areas of regression:
Overlay
setStatewarnings.