Replace deprecated commands with new dart commands#741
Merged
rm-astro-wf merged 2 commits intomasterfrom Apr 26, 2022
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
greglittlefield-wf
approved these changes
Apr 26, 2022
Contributor
greglittlefield-wf
left a comment
There was a problem hiding this comment.
+10
@Workiva/release-management-p
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Sourcegraph batch replaces deprecated commands from the Dart SDK with the new ones.
All new CLI commands now live under the main
dartexecutable. See this issue for the detailsdart-lang/sdk#46100
This PR might need to be checked or tweaked for possible errors in the arguments to
dart analyzeanddart formatsince they take slightly different arguments than the original.In most cases for analyze all the arguments can be removed and it can just be
dart analyze.Some of the argument changes were difficult to match and replace in an automated way. Since
there are only a few places that might break, it'll be easier to let the batch create the PR
and then manually adjust them.
Argument changes for dartfmt -> dart format
-wshould be removed automatically since overwriting files is now the default. But, if you spot one, remove it.--dry-runis not a supported argument now. Replace with--set-exit-if-changed -o nonerepos that look like they will need updates for dart format
Argument changes for dartanalyzer -> dart analyze
--no-hintsand--no-lintsare removedrepos that look like they will need updates for dart analyze
QA steps:
dart analyzeordart formatcheck the argumentsCreated by Sourcegraph batch change
Workiva/dart_commands.