FED-734 CI cleanup: remove failing stable config, add 2.18 config#805
Merged
rmconsole7-wk merged 16 commits intomasterfrom Feb 8, 2023
Merged
FED-734 CI cleanup: remove failing stable config, add 2.18 config#805rmconsole7-wk merged 16 commits intomasterfrom
rmconsole7-wk merged 16 commits intomasterfrom
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
| dependencies: | ||
| color: any | ||
| memoize: ^2.0.0 | ||
| meta: ^1.6.0 # Workaround to avoid https://github.com/dart-lang/sdk/issues/46142 |
Contributor
Author
There was a problem hiding this comment.
These comments were outdated, so I cleaned them up
| expect(result2, same(result1), reason: 'should have returned the same object'); | ||
| }, tags: 'no-ddc'); | ||
|
|
||
| test('unless the runtime is the DDC', () { |
Contributor
Author
There was a problem hiding this comment.
Basically, before we were testing that caching wasn't happening in DDC, which wasn't really the behavior we wanted ensure. I replaced it with a test that validates that it doesn't break, which is really the behavior we're after, at least for older SDKs.
Failures look like:
Failed to load "test/over_react_component_declaration_test.dart": Timed out waiting for Chrome to connect
robbecker-wf
approved these changes
Feb 8, 2023
Member
robbecker-wf
left a comment
There was a problem hiding this comment.
Looks good. Thanks for the detailed comments on why things were done.
evanweible-wf
approved these changes
Feb 8, 2023
Member
|
QA+1 CI Passes on 2.13 and 2.18 |
Contributor
Author
|
@Workiva/release-management-p |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Changes
part_of_different_libraryerrorsdartanalyzercommand removed in newer SDKsbuild_runnerRelease Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: