FED-1568 Run CI on test_consume_ branches with slashes#833
Merged
rmconsole7-wk merged 1 commit intomasterfrom Aug 22, 2023
Merged
FED-1568 Run CI on test_consume_ branches with slashes#833rmconsole7-wk merged 1 commit intomasterfrom
rmconsole7-wk merged 1 commit intomasterfrom
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
sydneyjodon-wk
approved these changes
Aug 22, 2023
Contributor
sydneyjodon-wk
left a comment
There was a problem hiding this comment.
+10
- GitHub Actions validation doesn't fail on this PR
- GitHub Actions CI runs on latest commit of the test branch linked above (which has these wildcard changes merged in)
Contributor
|
@Workiva/release-management-p |
This was referenced Sep 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Similar to #725:
it appears that
test_consume_branch wildcard wasn't set up right, preventing it from being run on branches containing slashes.For example, CI is not running on this test branch's original commit: master...test_consume_workiva/react-dart_366_over_react
Changes
Update
test_consume_wildcard to include slashes.Release Notes
N/A (internal CI updates)
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: