Skip to content

FED-1568 Run CI on test_consume_ branches with slashes#833

Merged
rmconsole7-wk merged 1 commit intomasterfrom
greglittlefield-wf-patch-3
Aug 22, 2023
Merged

FED-1568 Run CI on test_consume_ branches with slashes#833
rmconsole7-wk merged 1 commit intomasterfrom
greglittlefield-wf-patch-3

Conversation

@greglittlefield-wf
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf commented Aug 21, 2023

Motivation

Similar to #725:

From the GitHub Actions docs:

The * wildcard matches any character, but does not match slash (/).

The ** wildcard matches any character including slash (/) in branch and tag names.

This PR updates to use ** instead of * so that GitHub Actions run on all branches, as opposed to skipping branches containing slashes.

it appears that test_consume_ branch wildcard wasn't set up right, preventing it from being run on branches containing slashes.

For example, CI is not running on this test branch's original commit: master...test_consume_workiva/react-dart_366_over_react

Changes

Update test_consume_ wildcard to include slashes.

Release Notes

N/A (internal CI updates)

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed
    • Steps from PR author:
      • GitHub Actions validation doesn't fail on this PR
      • GitHub Actions CI runs on latest commit of the test branch linked above (which has these wildcard changes merged in)
    • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary-wf
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@rmconsole5-wk rmconsole5-wk changed the title Run CI on test_consume_ branches with slashes FED-1568 Run CI on test_consume_ branches with slashes Aug 21, 2023
@greglittlefield-wf greglittlefield-wf marked this pull request as ready for review August 21, 2023 21:43
@greglittlefield-wf greglittlefield-wf requested review from a team and kealjones-wk and removed request for a team August 21, 2023 21:44
Copy link
Contributor

@sydneyjodon-wk sydneyjodon-wk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

  • GitHub Actions validation doesn't fail on this PR
  • GitHub Actions CI runs on latest commit of the test branch linked above (which has these wildcard changes merged in)

@sydneyjodon-wk
Copy link
Contributor

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole7-wk rmconsole7-wk merged commit ab68964 into master Aug 22, 2023
@rmconsole7-wk rmconsole7-wk deleted the greglittlefield-wf-patch-3 branch August 22, 2023 00:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants