Skip to content

FED-2046 Backpatch disableRequiredPropValidation annotation arg#879

Merged
rmconsole5-wk merged 4 commits intomasterfrom
backpatch-disable-required-props-validation-annotation-arg
Jan 26, 2024
Merged

FED-2046 Backpatch disableRequiredPropValidation annotation arg#879
rmconsole5-wk merged 4 commits intomasterfrom
backpatch-disable-required-props-validation-annotation-arg

Conversation

@sydneyjodon-wk
Copy link
Contributor

Motivation

Backpatch new annotation arg to over_react v4 (they won't do anything until v5) so that we can use them in wdesk_sdk (and probably other places) when preparing for the migration to over_react v5

Changes

  • Backpatch disableRequiredPropValidation annotation arg

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

  • Tests were updated and provide good coverage of the changeset and other affected code
  • Manual testing was performed if needed

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

  • A Frontend Frameworks Design member has reviewed these changes
  • There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
  • For release PRs - Version metadata in Rosie comment is correct

@aviary3-wk
Copy link

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@sydneyjodon-wk sydneyjodon-wk marked this pull request as ready for review January 25, 2024 23:44
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10 with some #nits

Co-authored-by: Greg Littlefield <greg.littlefield@workiva.com>
Copy link
Contributor

@greglittlefield-wf greglittlefield-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@sydneyjodon-wk
Copy link
Contributor Author

@Workiva/release-management-p

Copy link

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole5-wk rmconsole5-wk merged commit e44a355 into master Jan 26, 2024
@rmconsole5-wk rmconsole5-wk deleted the backpatch-disable-required-props-validation-annotation-arg branch January 26, 2024 00:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants