Skip to content

w_common v2 rollout - 1 of 2 raise max#168

Merged
rm-astro-wf merged 1 commit intomasterfrom
batch/fedx/w_common_v2
Sep 28, 2022
Merged

w_common v2 rollout - 1 of 2 raise max#168
rm-astro-wf merged 1 commit intomasterfrom
batch/fedx/w_common_v2

Conversation

@sourcegraph-wk
Copy link
Copy Markdown

Summary

Frontend Frameworks is updating dependencies! More details at
https://wiki.atl.workiva.net/display/CP/Dependency+Upgrades

This update will allow w_common 2x by raising the max to < 3.0.0
It also raises the minimum of a few packages that addressed w_common
v2 breaking changes. In order to be compatible with w_common v2, we
need at least these versions.
dart_dev_workiva 1.5.9
wdesk_sdk 3.7.8
w_router 1.1.15
w_flux 2.10.21
w_module 2.0.30
bigsky_rest_files 1.33.10

In addition, sass compilation was moved out of w_common into a
w_common_tools package, so if it detects that the repo might need it,
it might add a dependency on w_common_tools.

Lastly, app/pubspec.lock files may have needed to be updated to get
those minimum versions of packages

For more info, reach out to #support-frontend-architecture on Slack.

Created by Sourcegraph batch change Workiva/w_common_v2.

@aviary2-wf
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@robbecker-wf robbecker-wf marked this pull request as ready for review September 27, 2022 04:20
@robbecker-wf
Copy link
Copy Markdown
Member

Newer Dart versions like stable, beta, dev are known to not work until we can upgrade dependencies. Skipping.

@autobot-wf
Copy link
Copy Markdown

Skynet test results failed initially for this build but were approved by rob.becker
https://wf-skynet-hrd.appspot.com/apps/test/smithy/3941920/2
Approval message: known github actions stages are failing. We are skipping newer versions of dart for now.

Copy link
Copy Markdown
Member

@robbecker-wf robbecker-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+10

@robbecker-wf
Copy link
Copy Markdown
Member

@Workiva/release-management-p

Copy link
Copy Markdown
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rm-astro-wf rm-astro-wf merged commit cd6e298 into master Sep 28, 2022
@rm-astro-wf rm-astro-wf deleted the batch/fedx/w_common_v2 branch September 28, 2022 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants