FEA-2771 Add ActionV2 w/o null safety#188
Merged
rmconsole5-wk merged 7 commits intomasterfrom Nov 3, 2023
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Contributor
evanweible-wf
left a comment
There was a problem hiding this comment.
Just some nits, otherwise LGTM. I'm also still working on a spike with Action0 and Action1 (for arity 0 and arity 1 since we talked about that alternative - we can compare them and see what we think.
Member
todbachman-wf
left a comment
There was a problem hiding this comment.
I've just got some nits around the tests.
todbachman-wf
previously approved these changes
Nov 1, 2023
todbachman-wf
previously approved these changes
Nov 2, 2023
evanweible-wf
previously approved these changes
Nov 2, 2023
| /// | ||
| /// If the `Store` has been disposed, this method throws a [StateError]. | ||
| void triggerOnActionV2<T>(Action<T> action, | ||
| void triggerOnActionV2<T>(ActionV2<T> action, |
Contributor
There was a problem hiding this comment.
😆 this method name now works on two different levels
4c474cb
todbachman-wf
approved these changes
Nov 3, 2023
Contributor
Author
|
QA +1
|
Contributor
Author
|
@Workiva/release-management-p ready to merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Adding APIs in major versions introduces risk, since consumers with opened ranges could accidentally consume new APIs. So instead of exposing Action2 in w_flux 3.0, we will backpatch Action2 to a w_flux 2.x minor, so that it won't be an API addition in w_flux 3.0. This option enables us to start work on the Action migration before the w_flux major release has finished rolling out
Changes
Add Action2 and appropriate test coverage without null safety work.
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: