Null safety 3

[sorenthompson-wk]

Motivation

Now that we have implemented ActionV2 in w_flux 2.11.0 we can safely migrate this repo to null-safety

Changes

Run the dart migrate tool for the root app and the example app

Release Notes

Review

See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.

Please review:

QA Checklist

• Tests were updated and provide good coverage of the changeset and other affected code
• Manual testing was performed if needed
  • Steps from PR author:
  • Anything falling under manual testing criteria outlined in CONTRIBUTING.md

Merge Checklist

While we perform many automated checks before auto-merging, some manual checks are needed:

• A Frontend Architecture member has reviewed these changes
• There are no unaddressed comments - this check can be automated if reviewers use the "Request Changes" feature
• For release PRs - Version metadata in Rosie comment is correct

[robbecker-wf]

I think we should use the replacements available since 2.16 https://dart.dev/tools/analysis#enabling-additional-type-checks
which would mean we'd also need to raise the SDK minimum to at least 2.16

analyzer:
  language:
    strict-casts: true

[sorenthompson-wk]

Will this replace:

analyzer:
    strong-mode:
        implicit-casts: true
        implicit-dynamic: true

or just implicit-casts: true

[robbecker-wf]

It would replace the whole strong-mode block.
implicit-dynamic: true is the default and doesn't do anything, so can safely be removed.

[robbecker-wf]

TODO Once react releases, we'll need to remove this override and set the react dependency minimum to the new react release (line 12 above)

[robbecker-wf]

#nit The migration tool seems to love to add the as casts ... is this needed or can it be fixed a different way? Since the tests pass, then I consider this optional.

[sorenthompson-wk]

It looks like it is not needed. I removed the cast and the analyzer seems ok with it.

[aviary3-wk]

Security Insights

No security relevant content was detected by automated scans.

Action Items

• Review PR for security impact; comment "security review required" if needed or unsure
• Verify aviary.yaml coverage of security relevant code

---

Questions or Comments? Reach out on Slack: #support-infosec.

[evanweible-wf]

This file name should be analysis_options.yaml

[sorenthompson-wk]

@Workiva/release-management-p ready to merge 🎉

[rmconsole-wf]

+1 from RM