FEA-2770 FEA-2772 Action v2 type migration#195
Merged
rmconsole7-wk merged 16 commits intomasterfrom Jan 12, 2024
Merged
Conversation
Security InsightsNo security relevant content was detected by automated scans. Action Items
Questions or Comments? Reach out on Slack: #support-infosec. |
Address review comments
evanweible-wf
previously approved these changes
Dec 19, 2023
Contributor
evanweible-wf
left a comment
There was a problem hiding this comment.
This is looking good to me! Let's run it in a few more repos to see if we can catch any other edge cases. Once we feel good about that, we can get this merged and released.
evanweible-wf
approved these changes
Jan 11, 2024
Contributor
|
LGTM! I ran this in wdesk_sdk and graph_app again and it works great! Had to make two manual changes in wdesk_sdk, but none in graph_app. Let's ship it! |
Contributor
|
QA +1 |
Contributor
|
@Workiva/release-management-p |
Contributor
Author
|
@Workiva/release-management-p send it |
kirkrichardson-wk
approved these changes
Jan 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
W_flux Action to ActionV2 codemod
Changes
make codemod to migrate Action to ActionV2
Release Notes
Review
See CONTRIBUTING.md for more details on review types (+1 / QA +1 / +10) and code review process.
Please review:
QA Checklist
Merge Checklist
While we perform many automated checks before auto-merging, some manual checks are needed: