Skip to content

FEDX-1708: Workiva Analysis Options v2#199

Merged
rmconsole3-wf merged 2 commits intomasterfrom
batch/fedx/workiva_analysis_options_v2
Oct 17, 2024
Merged

FEDX-1708: Workiva Analysis Options v2#199
rmconsole3-wf merged 2 commits intomasterfrom
batch/fedx/workiva_analysis_options_v2

Conversation

@sourcegraph-wk
Copy link
Copy Markdown

@sourcegraph-wk sourcegraph-wk commented Sep 13, 2024

FEDX-1708

Issue Status

This PR bumps/adds workiva_analysis_options to v2. This is being done in an effort to adopt consistency in
analysis_options.yaml files across the codebase, and ensure all developers are using the most up to date
functionality that the dart analyzer can provide.

Failing CI will be evaluated by someone from FEDX and resolved. We will reach out when the pr is ready for review.

If you have any questions, concerns, or opinions, please reach out to #support-frontend-dx.

Created by Sourcegraph batch change Workiva/workiva_analysis_options_v2.

@aviary2-wf
Copy link
Copy Markdown

Security Insights

No security relevant content was detected by automated scans.

Action Items

  • Review PR for security impact; comment "security review required" if needed or unsure
  • Verify aviary.yaml coverage of security relevant code

Questions or Comments? Reach out on Slack: #support-infosec.

@bender-wk bender-wk changed the title Workiva Analysis Options v2 FEDX-1708: Workiva Analysis Options v2 Oct 7, 2024
@dustinlessard-wf dustinlessard-wf marked this pull request as ready for review October 13, 2024 16:31
include: package:workiva_analysis_options/v2.yaml
# analysis_options.yaml docs: https://www.dartlang.org/guides/language/analysis-options
analyzer:
exclude:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we remove the linter rules below?

Ideally we want to just rely on workiva_analysis_options

@sourcegraph-wk sourcegraph-wk force-pushed the batch/fedx/workiva_analysis_options_v2 branch from 7adb72e to 65913a4 Compare October 16, 2024 21:10
@robbecker-wf
Copy link
Copy Markdown
Member

QA+1 CI passes @Workiva/release-management-p

Copy link
Copy Markdown
Contributor

@rmconsole-wf rmconsole-wf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from RM

@rmconsole3-wf rmconsole3-wf merged commit 2097b6d into master Oct 17, 2024
@rmconsole3-wf rmconsole3-wf deleted the batch/fedx/workiva_analysis_options_v2 branch October 17, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants