Skip to content

Rollout React 18 to tests and example apps #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
btr-rmconsole-2 merged 3 commits into from
Jul 23, 2025
Merged

Rollout React 18 to tests and example apps #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f1417cb
Update tests and example apps to run on React 18
sourcegraph-commit-signing-app[bot] Jul 18, 2025
1eb60cb
Get example app running again
todbachman-wf Jul 23, 2025
a2ad48b
Update changelog for last release
todbachman-wf Jul 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,11 @@
# Changelog

## 3.0.1
Check out the detailed [release notes](//github.com/Workiva/w_flux/releases/tag/3.0.1).

- Completed migration to ActionV2.
- Dependency and CI improvements.

## 3.0.0
Migrate w_flux to null-safety.

Expand Down
3 changes: 2 additions & 1 deletion example/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,11 @@ publish_to: none
environment:
sdk: '>=2.19.0 <3.0.0'
dependencies:
over_react: ^5.4.5
w_flux:

dev_dependencies:
react: ^7.0.0
react: ^7.3.0
build_runner: ^2.0.0
build_web_compilers: '>=3.0.0 <5.0.0'
dart_dev: ^4.0.0
Expand Down
2 changes: 1 addition & 1 deletion example/web/random_color/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<body>
<div id="content-container"></div>

<script src="packages/react/react_with_react_dom_prod.js"></script>
<script src="packages/react/js/react.min.js"></script>
<script defer src="random_color.dart.js"></script>

</body>
Expand Down
1 change: 0 additions & 1 deletion example/web/todo_app/actions.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,5 @@ import 'store.dart';
class ToDoActions {
final Action<Todo> createTodo = Action<Todo>();
final Action<Todo> completeTodo = Action<Todo>();
final Action<Todo> deleteTodo = Action<Todo>();
final Action clearTodoList = Action<Todo>();
}
2 changes: 1 addition & 1 deletion example/web/todo_app/components/todo_list_item.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ import '../store.dart';
var TodoListItem = react.registerComponent(() => _TodoListItem());

class _TodoListItem extends react.Component2 {
Todo get todo => props['todo'] as String;
Todo get todo => props['todo'] as Todo;
Function get onClick => props['onClick'] as Function;

get defaultProps => {'todo': null};
Expand Down
2 changes: 1 addition & 1 deletion example/web/todo_app/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<body>
<div id="content-container"></div>

<script src="packages/react/react_with_react_dom_prod.js"></script>
<script src="packages/react/js/react.min.js"></script>
<script defer src="todo_app.dart.js"></script>

</body>
Expand Down
5 changes: 2 additions & 3 deletions example/web/todo_app/store.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,10 +27,9 @@ class ToDoStore extends Store {
ToDoActions _actions;

ToDoStore(ToDoActions this._actions) {
triggerOnActionV2(_actions.createTodo, (Todo todo) => _todos.add(todo));
triggerOnActionV2(_actions.createTodo, (Todo? todo) => _todos.add(todo!));
triggerOnActionV2(
_actions.completeTodo, (Todo todo) => todo.completed = true);
triggerOnActionV2(_actions.deleteTodo, (Todo todo) => _todos.remove(todo));
_actions.completeTodo, (Todo? todo) => todo!.completed = true);
triggerOnActionV2(_actions.clearTodoList, (_) => _todos = []);
}
}
Expand Down
2 changes: 1 addition & 1 deletion pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ environment:

dependencies:
meta: ^1.16.0
react: ^7.0.0
react: ^7.3.0
w_common: ^3.0.0

dev_dependencies:
Expand Down