This repository was archived by the owner on Jan 16, 2026. It is now read-only.
fix the bug in thermal loss for gaussian backend#746
Open
sylviemonet wants to merge 1 commit intomasterfrom
Open
fix the bug in thermal loss for gaussian backend#746sylviemonet wants to merge 1 commit intomasterfrom
sylviemonet wants to merge 1 commit intomasterfrom
Conversation
elib20
approved these changes
May 14, 2024
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context: The thermal loss factor was added to the full nmatrix of the object in the backend, but it shouldn't be.
Description of the Change: Rewrite the thermal loss.
Benefits:
Possible Drawbacks: the variable "k" doesn't have a type hint so it is considered as int here, which may cause problems in the future.
Related GitHub Issues: