Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #405 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 28 28
Lines 1922 1946 +24
=========================================
+ Hits 1922 1946 +24
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Collaborator
|
You might aswell remove the old one, no? |
Collaborator
Author
|
Do you want to keep the cutoff as an integer? the new implementation supports any shape. |
ziofil
commented
Oct 17, 2025
Collaborator
Author
|
@nquesada regarding the cutoff argument, I preserved the old API and made it possible to pass the full shape. |
nquesada
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context:
The beamsplitter in the Fock representation suffers from numerical instabilities even for moderate cutoffs (~40)
Description of the Change:
This ports the stable BS implementation from MrMustard, which is just as fast as the unstable BS and offers numerical stability up to arbitrary cutoffs (or at least I ran out of memory before I could notice any).
Benefits:

BS can now be applied to high photon number inputs and outputs. It is as fast as the unstable implementation:
But stable:

Possible Drawbacks:
None
Related GitHub Issues:
None