Skip to content

Sort the emote picker list by match score instead of alphabetical order#656

Merged
Xithrius merged 1 commit intoXithrius:mainfrom
Nogesma:emote-picker-sort
Nov 10, 2024
Merged

Sort the emote picker list by match score instead of alphabetical order#656
Xithrius merged 1 commit intoXithrius:mainfrom
Nogesma:emote-picker-sort

Conversation

@Nogesma
Copy link
Contributor

@Nogesma Nogesma commented Nov 5, 2024

Switch to using a fuzzy finder for searching through the emote list. Also sorts them using their match score.

@codecov
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 58 lines in your changes missing coverage. Please review.

Project coverage is 22.83%. Comparing base (18a10b6) to head (b1903fc).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/ui/components/emote_picker.rs 0.00% 58 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #656      +/-   ##
==========================================
- Coverage   22.87%   22.83%   -0.05%     
==========================================
  Files          42       42              
  Lines        5430     5440      +10     
==========================================
  Hits         1242     1242              
- Misses       4188     4198      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@Xithrius Xithrius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very cool. Thanks!

@Xithrius Xithrius merged commit acbfc1d into Xithrius:main Nov 10, 2024
@Nogesma Nogesma deleted the emote-picker-sort branch November 10, 2024 01:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants