Sprint 07#724
Open
s1zzen wants to merge 11 commits intoYandex-Practicum:project_sprint_3_startfrom
Open
Conversation
Helvetii951
reviewed
Feb 22, 2024
Comment on lines
+11
to
+15
| static var randomMovieRating: Float { | ||
| let randomFloat = Float.random(in: 1.0...10.0) | ||
| let intVal:Int = Int(randomFloat*10) | ||
| return Float(intVal)/10.0 | ||
| } |
There was a problem hiding this comment.
В приложении запрашиваются фильмы из топ - 250. Думаю, меньше 5-6 оценок там нет :) Я бы увеличил нижний предел.
Comment on lines
+84
to
+91
| /* | ||
| private let questions: [QuizQuestion] = [ | ||
| QuizQuestion(image: "The Godfather", | ||
| text: "Рейтинг этого фильма больше чем 6?", | ||
| correctAnswer: true), | ||
| QuizQuestion(image: "The Dark Knight", | ||
| text: "Рейтинг этого фильма больше чем 6?", | ||
| correctAnswer: true), |
There was a problem hiding this comment.
Это последний спринт модуля. Что-то вроде "релиза". Принято очищать код от лишних комментариев.
Comment on lines
+83
to
+86
| func testEndingAlert() { | ||
| for _ in 1...10{ | ||
| app.buttons["Yes"].tap() | ||
| } |
There was a problem hiding this comment.
Здесь желательно дбавить sleep(n) перед началом. Картинка может долго подгружать, тогда тест сломается. Как и в других тестах.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
столько работы проведено - а нет ни одной новой фичи ;( мне не нравится заниматься рефакторингом