This repository was archived by the owner on Aug 29, 2023. It is now read-only.
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I've made some changes to the metric reporter to be generic using abstract methods.
In this PR I've added Prometheus support, but the idea is to let users extend it to whatever metric reporters they are using as long as they implement the BaseRes abstract method:
https://github.com/EladLeev/kafka-utils/blob/prometheus_support/kafka_utils/kafka_rolling_restart/response.py
Using it in Production for few months now, but I didn't had a chance to finish it up with tests, proper documentation, and to resolve conflicts from main branch 🥲 -- if anyone want to assist, more than welcome!
Might resolve this one as well -
#210
Thank you for the awesome project