Fix rank-based binding replacements getting dropped for multi-contribution classes in graph extensions#1584
Merged
ZacSweers merged 6 commits intoZacSweers:mainfrom Dec 24, 2025
Conversation
Contributor
JoelWilcox
commented
Dec 23, 2025
JoelWilcox
commented
- This works around the root issue where we can't access repeated annotations or their Container annotation in IR: https://youtrack.jetbrains.com/issue/KT-83185.
- Also updates the existing IR merging code to include ContributesBinding.Container annotations once the Kotlin fix is available; then we can just delete the interop code.
…ution classes in graph extensions - This works around the root issue where we can't access repeated annotations or their Container annotation in IR: https://youtrack.jetbrains.com/issue/KT-83185. - Also updates the existing IR merging code to include ContributesBinding.Container annotations once the Kotlin fix is available; then we can just delete the interop code.
ZacSweers
approved these changes
Dec 23, 2025
vRallev
approved these changes
Dec 23, 2025
… found - Otherwise we risk a different type of bug where contributions in the merging module are missed.
auto-merge was automatically disabled
December 23, 2025 02:31
Head branch was pushed to by a user without write access
…xtension * main: Fix bug preventing scope argument from being used in position other than first (ZacSweers#1589) Add binary metrics + limit scenarios tested (ZacSweers#1586) Move accesors to be contributed (ZacSweers#1585) Introduce `@ComptimeOnly` + stub binds in origin (ZacSweers#1582) More benchmark work (ZacSweers#1581)
JoelWilcox
deleted the
joel/duplicate-bindings-with-rank-in-graph-extension
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.