Skip to content

uggest change for security concern#7

Open
YYTVicky wants to merge 1 commit intoa0x8o:masterfrom
YYTVicky:patch-1
Open

uggest change for security concern#7
YYTVicky wants to merge 1 commit intoa0x8o:masterfrom
YYTVicky:patch-1

Conversation

@YYTVicky
Copy link
Copy Markdown

@YYTVicky YYTVicky commented Mar 6, 2020

More detailed description of your change,
if necessary. The PR title and PR message become
the squashed commit message, so use a separate
comment to ping reviewers.

Summary of testing strategy (including rationale)
for the feature or bug fix. Unit and/or integration
tests are expected for any behaviour change and
system tests should be considered for larger changes.

Committer Checklist (excluded from commit message)

  • Verify design and implementation
  • Verify test coverage and CI build status
  • Verify documentation (including upgrade notes)

@YYTVicky
Copy link
Copy Markdown
Author

Hi,
we commend the key should be random generated for security reason, we have a recommend code patch:
SecureRandom random = new SecureRandom();
String key= String.valueOf(random.nextInt());
byte[] key = defaultKey.getBytes();
key = Arrays.copyOf(keyBytes,24);
Hope it can helps and looking forward to hearing any feedback from you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant