feat: Add support for more Task Message and Artifact fields in the Vertex Task Store#908
Draft
gaborfeher wants to merge 7 commits intoa2aproject:mainfrom
Draft
feat: Add support for more Task Message and Artifact fields in the Vertex Task Store#908gaborfeher wants to merge 7 commits intoa2aproject:mainfrom
gaborfeher wants to merge 7 commits intoa2aproject:mainfrom
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/contrib/tasks/vertex_task_converter.py | 96.36% | 92.68% | 🔴 -3.68% |
| Total | 91.73% | 91.71% | 🔴 -0.02% |
Generated by coverage-comment.yml
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request enhances the Vertex AI task converter by implementing comprehensive metadata handling and message conversion logic. It introduces versioned metadata packing/unpacking and updates artifact and task conversion to include fields such as name, description, and status details. Review feedback highlights a potential Pydantic validation error when handling invalid roles in to_sdk_message and suggests improving naming consistency for reference task IDs within the metadata dictionary.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for the following fields:
For #751