Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a feature for filtering rows from the halo table on a per-superslab basis as they are loaded into memory. This saves memory, since the full, unfiltered table never needs to be constructed. Syntax is a function passed to the CHC constructor, often a lambda:
If requesting subsamples, only the subsamples from the surviving halos are loaded, but the peak memory usage is still higher than it needs to be. This part of the code needs a refactor anyways (#7), but that's a future issue.
This required a bit of refactoring of how the cleaning files are read; now the original and cleaned files are read as a pair for each superslab, rather than all the originals, then all the cleaning.