Merged
Conversation
…pos/vel_avg where there is no information available
lgarrison
requested changes
Feb 21, 2022
Member
lgarrison
left a comment
lgarrison
left a comment
There was a problem hiding this comment.
Looks good! Can you just check the one comment? Also, does the URL that's printed actually contain any info about the LC catalogs yet? Should we open an issue as a to-do to explain the LC halo catalog fields on the website?
Comment on lines
+987
to
+990
| if m[0] == 'pos_interp': | ||
| columns['pos_interp'] = np.where(interped[:, None], raw['pos_avg'], raw['pos_interp']) | ||
| if m[0] == 'vel_interp': | ||
| columns['vel_interp'] = np.where(interped[:, None], raw['vel_avg'], raw['vel_interp']) |
Member
There was a problem hiding this comment.
Could you try adding back in the or 'pos_interp' in halos.colnames? I think it's needed to avoid duplicating the interped calculation. Likewise for vel.
Collaborator
Author
There was a problem hiding this comment.
Yep, thanks! added back the check and also added https://abacussummit.readthedocs.io/en/latest/data-products.html#halo-light-cone-catalogs
Member
|
Looks good to me, thanks! |
lgarrison
approved these changes
Feb 22, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solving issue #35 and closed issue #31