Conversation
- Increasd buffer size for smoother progress handler calling
abbeycode
commented
Apr 26, 2019
Owner
Author
abbeycode
left a comment
abbeycode
left a comment
There was a problem hiding this comment.
@amosavian Let's agree on the changes to make to this PR, and then I'll assign to you for review as I make the changes. I think that makes sense.
Owner
Author
|
Let's not sweat the unit test failures right now. Some tests are failing because there are fewer progress updates than expected due to the buffer increasing. |
Contributor
|
Thank you alot |
… updated unit tests to accommodate that new number
…file being extracted is a directory or not (Issue #74)
Owner
Author
|
This is ready again for @amosavian to take a look. I updated the way directories are created and removed some dead code i discovered along the way. |
Owner
Author
|
@amosavian Do you think you'll have a chance to take a look soon? Or should I go ahead and merge it in? |
Contributor
|
I'm looking now thanks |
amosavian
reviewed
May 9, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch contains @amosavian's changes from PR #78 applied to the
v1.9branch. I'm going to review them here, and we'll make a squash merge to v1.9 with the changes made. If @amosavian likes to, he can create a PR against this branch, but it might get more confusing than it already is :-)