core: rework apple silicon device detection

[abiosoft]

No description provided.

[Copilot]

Pull request overview

This PR refactors the Apple Silicon chip detection logic in util/macos.go to prevent system_profiler from being called on non-macOS platforms (e.g., Linux). It replaces the old IsMx(x int) function with a new IsMxOrNewer(min int) function that checks if the chip generation is at least min, and introduces a chipTypeDetector interface (with a systemProfilerChipDetector production implementation) to enable testing without invoking real system commands.

Changes:

• IsMx is replaced by IsMxOrNewer(min int), which returns true when the chip is an Apple Silicon M{n} with n >= min.
• A chipTypeDetector interface and systemProfilerChipDetector struct are introduced; GetChipType() now guards with MacOS() before calling system_profiler, preventing the call on Linux.
• New tests in util/macos_test.go cover parseMNumber and IsMxOrNewer using a fakeDetector to stub the chip type.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
util/macos.go	Replaces IsMx with IsMxOrNewer, adds chipTypeDetector interface, guards system_profiler call with MacOS(), extracts parseMNumber helper
util/macos_test.go	New test file with table-driven tests for parseMNumber and IsMxOrNewer using a fake detector

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.