switches to specify vertical and horizontal char densities#129
switches to specify vertical and horizontal char densities#129romangrothausmann wants to merge 7 commits intoabishekvashok:masterfrom
Conversation
Merge stable with changes from master
Version bump!
Update version!
abishekvashok
left a comment
abishekvashok
left a comment
There was a problem hiding this comment.
These changes make sense. Thank you for your time. Potentially we could add a linter to this project. I can merge this but it would be much more easier if you could fix the merge conflicts. Again, thanks for working on this.
Thanks @abishekvashok, conflicts to master resolved. |
abishekvashok
left a comment
abishekvashok
left a comment
There was a problem hiding this comment.
Tiny nits that would make me happy :)
| update = keypress - 48; | ||
| break; | ||
| case 'm': | ||
| space += 10; |
There was a problem hiding this comment.
The indentation seems off in some places like this line for example. Can you please fix this
| rainbow = 1; | ||
| break; | ||
| case 'm': | ||
| case 'M': |
There was a problem hiding this comment.
Instead of modifying an existing option, can we switch the new option to use another letter or capital M if no other letters seem fit for the cause?
| int lock = 0; | ||
| cmatrix **matrix = (cmatrix **) NULL; | ||
| int *length = NULL; /* Length of cols in each line */ | ||
| int space = 50; /* vertical density parameter */ |
There was a problem hiding this comment.
Can we make them constants? (I am not sure if we modify them later, can you check?)
2 participants
This PR (originally based on v1.2a) offers switches to specify vertical and horizontal character densities and the options to change these during run-time.