Adds support for japanese characters#73
Merged
abishekvashok merged 2 commits intomasterfrom Mar 27, 2019
Merged
Conversation
Adds classic mode which can be invoked with "c", which uses Japanese characters instead of the regular English characters that cmatrix outputed earlier. Done to match up with the original matrix. The starting, ending, and range for randum number (corresponding to the unicode character) is modified to suite the Japanese character range. Requires appropriate Japanese fonts to make it work. Fixes #57 Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
Modifies code to calculate randnum from values of highnum and randmin which are used for matrix randum unicode generation. The last implementation contained hardcoded values. Signed-off-by: Abishek V Ashok <abishekvashok@gmail.com>
|
How do I install fonts? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds classic mode which can be invoked with "c", which uses Japanese
characters instead of the regular English characters that cmatrix
outputed earlier. Done to match up with the original matrix.
The starting, ending, and range for randum number (corresponding to the
unicode character) is modified to suite the Japanese character range.
Requires appropriate Japanese fonts to make it work.
Fixes #57
The second commit:
Modifies code to calculate randnum from values of highnum and randmin
which are used for matrix randum unicode generation. The last
implementation contained hardcoded values.