Temporary solution for #83 to allow for use of config.h with cmake#84
Merged
Merged
Conversation
…with cmake This commit provides a temporary fix for abishekvashok#83 that caused cmatrix to add a background color, instead of using the default terminal background. This issue is only present in cmake builds. CMakeLists.txt now checks to see if a `config.h` is present. If a `config.h` is not available, it will add the preprocessor definition EXCLUDE_CONFIG_H as it has prior. However, if a config.h is present, we will use that instead. This allows a user to run `autoreconf -i && ./configure` before running `cmake` and finally, `make`.
Owner
|
Thanks for working on it :) |
Contributor
Author
|
yeah no problem! If I find time I may look into it improving it further 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit provides a temporary fix for #83 that caused cmatrix to add a background color, instead of using the default terminal background. This issue is only present in cmake builds.
CMakeLists.txt now checks to see if a
config.his present. If aconfig.his not available, it will add the preprocessor definition EXCLUDE_CONFIG_H as it has prior. However, if a config.h is present, we will use that instead. This allows a user to runautoreconf -i && ./configurebefore runningcmakeand finally,make.If this fix is accepted, I would recommend adding those to the build instructions in the README. Ideally, CMake should be able to make the
config.hfor us, but some work will need to be done to ensure it matches what autotools would output.On a slightly personal note, this will also require an update to the PKGBUILD (AUR) neither of which appear to be a separate branch available for editing. :)
Let me know what more I can do to help!