Open
Conversation
pombredanne
requested changes
Dec 30, 2024
Member
pombredanne
left a comment
There was a problem hiding this comment.
Thanks. Looking good!
Do you mind to amend the commit message?
We like to use imperative style.
Rather than "new bsd variant added as a rule", what about:
"Add BSD license detection rule #4018"
We have some doc on how to write good commit messages: See https://aboutcode.readthedocs.io/en/latest/contributing/writing_good_commit_messages.html
Member
|
Please also rename your PR using the imperative style, and apply the same approach to your other PRs. |
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
f765161 to
49b530f
Compare
Contributor
Author
|
Thanks for the suggestions @pombredanne , I've implemented them here and in other PRs. |
Member
|
Also the rule needs to be renamed to something that is unique to avoid conflicts. |
Signed-off-by: NucleonGodX <racerpro41@gmail.com>
Contributor
Author
Done! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4018
Tasks
Run tests locally to check for errors.
Signed-off-by: NucleonGodX manitsingh018@gmail.com