Skip to content

Conversation

@maliming
Copy link
Member

Resolve #24806

Copilot AI review requested due to automatic review settings February 11, 2026 06:50
@maliming maliming added this to the 10.1-final milestone Feb 11, 2026
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts EF Core navigation-change tracking lifecycle in AbpDbContext to better support auditing/navigation change detection across a Unit of Work, aiming to resolve #24806 where role changes can yield missing NewValue in audit logs.

Changes:

  • Replace removal of modified navigation-tracking entries with a “reset modified flags” approach (ResetChangedFlags).
  • Defer clearing of AbpEfCoreNavigationHelper state until Unit of Work completion (or immediately when no UoW exists).

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/EntityFrameworkCore/ChangeTrackers/AbpEfCoreNavigationHelper.cs Renames the cleanup API and changes behavior from removing modified entries to resetting modification flags.
framework/src/Volo.Abp.EntityFrameworkCore/Volo/Abp/EntityFrameworkCore/AbpDbContext.cs Updates SaveChangesAsync cleanup to reset flags after save and clear helper state on UoW completion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant