Conversation
This partly reverts commit 609b24a. It reverts the JSON_REAL_PRECISION(16) part. So the above commit was made in an attempt to try and fix real numbers like 565.56 being shown/written as 565.55999999999995 and while it helped it didn't fix every case, like the above number. In the meantime jansson (the JSON library in use) gained a new mechanism for dealing with such things in the form of David M. Gay's dtoa work. This seems to resolve the issue, if you leave the default precision at 17. This patch is in the 2.14.1 release of jansson, so that kind of becomes a hard requirement for the proper functioning of all this. Link: <akheron/jansson@8b975ab> Link: <https://github.com/akheron/jansson/releases/tag/v2.14.1> Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
Signed-off-by: Andrew Clayton <ac@sigsegv.uk>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix displaying/writing of real numbers. Requires jansson 2.14.1