Skip to content

Comments

Undo indirect dependency updates from #627#632

Merged
joshmgross merged 1 commit intomainfrom
joshmgross/undo-dependency-changes
Oct 9, 2024
Merged

Undo indirect dependency updates from #627#632
joshmgross merged 1 commit intomainfrom
joshmgross/undo-dependency-changes

Conversation

@joshmgross
Copy link
Contributor

@joshmgross joshmgross commented Oct 9, 2024 •
edited
Loading

This is a revert of d50e660 to undo all of the indirect dependency updates from an npm audit fix.

git revert d50e66084c4d29dc5d3326b7a0e67bed9ef4bb1e --no-commit
npm i @actions/artifact@latest    
npm run release

One of these dependencies broke uploading artifacts through a proxy - #630. We're still investigating to figure out which one.

https://github.com/robherley/tmp-artifacts/actions/runs/11259345071/job/31308098535 confirms this fixes the issue.

@joshmgross joshmgross marked this pull request as ready for review October 9, 2024 16:59
@joshmgross joshmgross requested a review from a team as a code owner October 9, 2024 16:59
@joshmgross joshmgross merged commit b4b15b8 into main Oct 9, 2024
@joshmgross joshmgross deleted the joshmgross/undo-dependency-changes branch October 9, 2024 17:16
@Trimell2006 Trimell2006 mentioned this pull request Nov 17, 2024
Closed
tdfacer pushed a commit to ifit/upload-artifact that referenced this pull request Oct 7, 2025
@joshmgross
Merge pull request actions#632 from actions/joshmgross/undo-dependenc…
f746797 
…y-changes

Undo indirect dependency updates from actions#627
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@robherley robherley robherley approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joshmgross @robherley