chore: Use datetime instead of time struct to include milliseconds information in gps.timestamp_utc#119
Open
daehwankim112 wants to merge 4 commits into
Open
chore: Use datetime instead of time struct to include milliseconds information in gps.timestamp_utc#119daehwankim112 wants to merge 4 commits into
daehwankim112 wants to merge 4 commits into
Conversation
tannewt
requested changes
Oct 21, 2025
Member
tannewt
left a comment
There was a problem hiding this comment.
Thanks for the PR!
datetime is an additional dependency that some boards may no longer be able to fit. How about adding a new datetime_us property that imports datetime when accessed? That way existing use will work without the additional dependency.
I realize the current datetime property is misnamed but I don't want to break existing code by changing it.
Author
|
Hello @tannewt ! Thank you for the feedback! I couldn't find anything about datetime_us. Can you please direct me where I can find more about it? Best regards, |
Member
|
I'm suggesting you add it instead of modifying the existing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello I have found that this library does not support milliseconds of GPS time.
I have created an issue but no update yet so I made my fix to add miliseconds in this library.
GlobalTop PMTK Command packet documentation from Adafruit suggests that reading NMEA can be set up to 10Hz. Therefore, we are able to read GPS time in precision of 100 milliseconds.
I have updated the examples accordingly as well. If you want to test it, don't forget to set the update rate using
PMTK220command. For example,