Add AOT to props and clean up in release#1181
Conversation
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (4 files)
|
There was a problem hiding this comment.
Pull request overview
Updates dependency management and project configuration to support AOT/trimming scenarios and align package references/locks for the release workflow.
Changes:
- Upgrades
Microsoft.SourceLink.GitHubreferences/lockfiles to10.0.102(with updated transitive packages). - Moves
Microsoft.SourceLink.GitHub/Microsoft.NETFramework.ReferenceAssembliesintoDirectory.Packages.propsasGlobalPackageReferences and cleans up per-project references. - Updates
SharpCompress.csprojto add an additional target framework and setsIsAotCompatiblefor net8/net10.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/SharpCompress.Test/packages.lock.json | Refreshes locked dependencies to reflect global/source link updates. |
| tests/SharpCompress.Test/SharpCompress.Test.csproj | Removes redundant per-project package reference and debug constants block. |
| tests/SharpCompress.Performance/packages.lock.json | Updates lockfile to include centrally referenced build-time packages. |
| src/SharpCompress/packages.lock.json | Updates lockfile for SourceLink upgrade and additional target framework restore graph. |
| src/SharpCompress/SharpCompress.csproj | Adjusts version placeholders, adds a target framework, and marks net8/net10 as AOT compatible. |
| build/packages.lock.json | Updates lockfile to reflect centrally referenced packages. |
| Directory.Packages.props | Switches SourceLink/ReferenceAssemblies to GlobalPackageReference and upgrades SourceLink version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@adamhathcock I've opened a new pull request, #1182, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: adamhathcock <527620+adamhathcock@users.noreply.github.com>
[WIP] WIP address feedback on AOT props and cleanup
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/SharpCompress/Common/Zip/WinzipAesEncryptionData.cs:27
Rfc2898DeriveBytesimplementsIDisposable, but the instances created in theNETFRAMEWORK || NETSTANDARD2_0and#elsebranches are not disposed. Wrap these in ausing(orusing var) to ensure cryptographic resources are released/cleared deterministically.
#if NETFRAMEWORK || NETSTANDARD2_0
var rfc2898 = new Rfc2898DeriveBytes(password, salt, RFC2898_ITERATIONS);
KeyBytes = rfc2898.GetBytes(KeySizeInBytes);
IvBytes = rfc2898.GetBytes(KeySizeInBytes);
var generatedVerifyValue = rfc2898.GetBytes(2);
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Release version of #1180
This pull request updates package references and project configuration to improve compatibility and bring dependencies up to date. The main changes include upgrading the
Microsoft.SourceLink.GitHubpackage to version 10.0.102, ensuring consistent usage ofMicrosoft.NETFramework.ReferenceAssemblies, and removing redundant or outdated project settings. These updates help maintain build reliability and better support for modern .NET features.Dependency updates:
Microsoft.SourceLink.GitHubto version 10.0.102 across all projects and lock files, replacing previous references to older versions and ensuring transitive dependencies (Microsoft.Build.Tasks.Git,Microsoft.SourceLink.Common) are also updated. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13]Microsoft.NETFramework.ReferenceAssemblies(version 1.0.3) in all relevant projects and lock files, including transitive dependency updates fornet461. [1] [2] [3] [4]Project configuration cleanup:
PackageReferenceand debug configuration blocks fromSharpCompress.csprojandSharpCompress.Test.csproj, simplifying the project files and avoiding duplicate package references. [1] [2] [3]netstandard20as a target framework inSharpCompress.csprojto improve cross-platform compatibility.IsAotCompatibletotruefor .NET 8.0 and 10.0 targets inSharpCompress.csproj, supporting ahead-of-time compilation scenarios.Versioning adjustments:
SharpCompress.csprojto0.0.0.0, likely to prepare for a new release or versioning strategy.Build system improvements:
Directory.Packages.propsto useGlobalPackageReferencefor key dependencies, streamlining package management.