return Stream.Null when 7z entry has no stream#854
Merged
adamhathcock merged 2 commits intoadamhathcock:masterfrom Apr 28, 2025
Merged
return Stream.Null when 7z entry has no stream#854adamhathcock merged 2 commits intoadamhathcock:masterfrom
adamhathcock merged 2 commits intoadamhathcock:masterfrom
Conversation
Owner
|
There should be a tested added but can merge just for consistency |
Contributor
Author
|
Yes. There should be an empty file in the tests\TestArchives\Original folder... but I don't know how to add that to all "exotic" archives in the tests\TestArchives\Archives folder (for example tests\TestArchives\Archives\7Zip.ZSTD.7z). So please add it. Thank you. |
This was referenced Aug 1, 2025
This was referenced Nov 24, 2025
This was referenced Jan 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bug: 7z file extraction fails when the archive contains empty file
I'm using the following code to extract a 7z file:
But it fails when the archive file (
data) contains an empy file.The same
GetCompressedStreammethod returnsStream.Null, I think this method should also returnStream.Nullinstead throwing an exception.It would be good to put an empy file to the tests\TestArchives\Original folder and to all the test files, to cover this case in the tests, but I don't know how to create them.