Skip to content

Fix volume FileName property potentially missing#921

Merged
adamhathcock merged 1 commit intoadamhathcock:masterfrom
Morilli:fix-volume-filename
Jul 7, 2025
Merged

Fix volume FileName property potentially missing#921
adamhathcock merged 1 commit intoadamhathcock:masterfrom
Morilli:fix-volume-filename

Conversation

@Morilli
Copy link
Contributor

@Morilli Morilli commented Jul 6, 2025

If the ReaderOptions has LeaveStreamOpen set (which is set to true by default), the stream used to report a volume's FileName was a NonDisposingStream instead of the originally passed in stream, which never worked.

Copy link
Owner

@adamhathcock adamhathcock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@adamhathcock adamhathcock merged commit 415f0c6 into adamhathcock:master Jul 7, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Volume's FileName doesn't work when readerOptions is specified

2 participants