Bug Fix: FileTransportOptions type missing lazy:boolean option (#2334)#1
Merged
adampweb merged 1 commit intoadampweb:masterfrom Jul 20, 2023
Merged
Bug Fix: FileTransportOptions type missing lazy:boolean option (#2334)#1adampweb merged 1 commit intoadampweb:masterfrom
adampweb merged 1 commit intoadampweb:masterfrom
Conversation
* Test for file Transport option rotationFormat * Test for file Transport option rotationFormat * Added Lazy option in file transport * Lint and test * removed only statement * Update test/unit/winston/transports/01-file-maxsize.test.js Co-authored-by: David Hyde <DABH@users.noreply.github.com> * Update test/unit/winston/transports/01-file-maxsize.test.js Co-authored-by: David Hyde <DABH@users.noreply.github.com> * Added lazy in FileTransportOptions types * Added lazy type in FileTransportInstance --------- Co-authored-by: myAlapi <myalapi2022@gmail.com> Co-authored-by: David Hyde <DABH@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test for file Transport option rotationFormat
Test for file Transport option rotationFormat
Added Lazy option in file transport
Lint and test
removed only statement
Update test/unit/winston/transports/01-file-maxsize.test.js
Update test/unit/winston/transports/01-file-maxsize.test.js
Added lazy in FileTransportOptions types
Added lazy type in FileTransportInstance