Open
Conversation
Author
|
I'm having trouble testing this because I can't echo I could repackage one of the docker images and provide it a more complex ENTRYPOINT, but I'm not sure how to do this.., any suggestions regarding the test @addnab ? |
Author
|
Any ideas on how to test, or just take it as is? @addnab |
Owner
|
Hi @yfarjoun I'll take a look on Friday if it's ok. I'll work on adding a test for this as well. |
Author
|
perfect! thanks. I just didn't want this to fall off your radar. I'm currently using a branch on my fork and I always prefer to move back to the "source" 😄 |
Author
|
I think that I don't like the design of this change...I'mm working on a different one. |
yfarjoun
force-pushed
the
yf_make_shell_replacement_optional
branch
from
0d29800 to
4360d75
Compare
yfarjoun
force-pushed
the
yf_make_shell_replacement_optional
branch
from
32fb57c to
7390192
Compare
author Yossi Farjoun <farjoun@broadinstitute.org> 1617479686 -0400 committer Yossi Farjoun <farjoun@broadinstitute.org> 1618455120 -0400 Change the way the script is run. instead of modfying the ENTRYPOINT, we will simply add the "shell" (default sh) and the "script_prefix" (default -c) and then the script. That way the possible comple entry point is not disturbed. if a user would like to remove the ENTRYPOINT they can provide an "option" "--entrypoint ''" for example.
yfarjoun
force-pushed
the
yf_make_shell_replacement_optional
branch
from
77360d1 to
2f4bbe9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR enables the use of images with complex default ENTRYPOINT arrays.
In essence, it leaves the original entry point as it by default and simply puts a "sh -c <script>" as the comment. if the user would like to remove the entry point they can put
--entrypoint=""as an option.If the user would like to not use a shell or a prefix (for example because their entry point already has that) they can redefine each of them separately.