Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #38 +/- ##
==========================================
- Coverage 93.72% 93.65% -0.08%
==========================================
Files 9 9
Lines 685 693 +8
==========================================
+ Hits 642 649 +7
- Misses 25 26 +1
Partials 18 18 ☔ View full report in Codecov by Sentry. |
adhocore
left a comment
There was a problem hiding this comment.
thanks again. before we merge, i would have to ask issue reproduction steps.
also are we sure it won't break anything?
|
btw ctrl+c handling is fixed in #41, does that help the issue this PR relates to? |
Signed-off-by: rfyiamcool <rfyiamcool@163.com>
094d1c2 to
bc068a5
Compare
|
ok i see, right now my concern is if the new changes here would break things or not |
adhocore
left a comment
There was a problem hiding this comment.
merging it for now but cant create a release as it has a concern unaddressed
summary
goroutine leak.
maybe happen cases:
ctxdonegoroutine don't exit.