Skip to content

fix: goroutine leak for tasker#38

Merged
adhocore merged 1 commit intoadhocore:mainfrom
rfyiamcool:fix/goroutine_leak_for_tasker
Mar 22, 2024
Merged

fix: goroutine leak for tasker#38
adhocore merged 1 commit intoadhocore:mainfrom
rfyiamcool:fix/goroutine_leak_for_tasker

Conversation

@rfyiamcool
Copy link
Contributor

summary

goroutine leak.

maybe happen cases:

  • if get linux signal, the ctxdone goroutine don't exit.
  • if get ctx done, the signal goroutine don't exit.

@rfyiamcool rfyiamcool requested a review from adhocore as a code owner March 11, 2024 07:25
@codecov-commenter
Copy link

codecov-commenter commented Mar 11, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.65%. Comparing base (b2e2c14) to head (bc068a5).

Files Patch % Lines
pkg/tasker/tasker.go 94.73% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #38      +/-   ##
==========================================
- Coverage   93.72%   93.65%   -0.08%     
==========================================
  Files           9        9              
  Lines         685      693       +8     
==========================================
+ Hits          642      649       +7     
- Misses         25       26       +1     
  Partials       18       18              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@adhocore adhocore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks again. before we merge, i would have to ask issue reproduction steps.

also are we sure it won't break anything?

@adhocore
Copy link
Owner

btw ctrl+c handling is fixed in #41, does that help the issue this PR relates to?

Signed-off-by: rfyiamcool <rfyiamcool@163.com>
@rfyiamcool rfyiamcool force-pushed the fix/goroutine_leak_for_tasker branch from 094d1c2 to bc068a5 Compare March 14, 2024 07:05
@rfyiamcool
Copy link
Contributor Author

btw ctrl+c handling is fixed in #41, does that help the issue this PR relates to?

the #41 pr can't fix the goroutine leak. 😁

@adhocore
Copy link
Owner

adhocore commented Mar 14, 2024

ok i see, right now my concern is if the new changes here would break things or not

Copy link
Owner

@adhocore adhocore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merging it for now but cant create a release as it has a concern unaddressed

@adhocore adhocore merged commit d84c389 into adhocore:main Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants