This repository was archived by the owner on Sep 2, 2021. It is now read-only.
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR:
I think this makes clearer what belong to brackets and will let me to move more things in these files.
GetElapsedMilliseconds,GetCurrentLanguageandGetExtensionJSSourcewere instance methods but AFAICT they didn't use anything from theclientAppclass.I'd appreciate if @redmunds @ingorichter @nethip could double check.
AppGetSupportDirectoryandAppGetDocumentsDirectorywere static methods so was easy to move them.I already started to move methods like
AppGetProductVersionStringandAppGetChromiumVersionStringto these files so to separate more cefclient code and brackets one.