This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Merged
Conversation
Member
|
@marcelgerber Is this mergable before the new CM lands? It seems like LanguageManager will emit console errors (at the least) since the mode doesn't exist yet. |
Contributor
Author
|
I haven't tested it, but it's probably best to wait for the CM merge. |
Contributor
Author
|
@peterflynn Time for review now that we have latest CM. |
Member
|
Cool, looks good! I find it weird that the mimetype starts with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new CM version (not yet in Brackets) has a Dart mode implemented.
For #6087.