This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Fix the misaligned selection extension when creating a folder#10402
Merged
marcelgerber merged 2 commits intoadobe:masterfrom Apr 30, 2016
Merged
Fix the misaligned selection extension when creating a folder#10402marcelgerber merged 2 commits intoadobe:masterfrom
marcelgerber merged 2 commits intoadobe:masterfrom
Conversation
Contributor
Author
|
Should be pretty safe as it's only a minor change. |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #9700.
The issue was that
.offset()was called on anatag with no contents (the folder has not yet a name...) and thus only 6px (padding) of height.cc @dangoor @ingorichter