Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Allow CSS Code Hints in PHP files#11635

Closed
sprintr wants to merge 1 commit intoadobe:masterfrom
sprintr:css-hints-in-php
Closed

Allow CSS Code Hints in PHP files#11635
sprintr wants to merge 1 commit intoadobe:masterfrom
sprintr:css-hints-in-php

Conversation

@sprintr
Copy link
Copy Markdown
Contributor

@sprintr sprintr commented Aug 27, 2015

Allow CSS Code Hints in style tags for PHP files. Fixes #11629

@marcelgerber
Copy link
Copy Markdown
Contributor

There are 3 more occurences of ctx.token.state in https://github.com/sprintr/brackets/blob/2e64c0dfd7ec8b15365438068720ce1fa59df480/src/language/CSSUtils.js#L1583-L1592

Please try to fix those as well. In my opinion, a helper function _getState would fit all cases the best.

@sprintr sprintr changed the title Fixes #11629 Allow CSS Code Hints in PHP files Aug 30, 2015
@abose
Copy link
Copy Markdown
Contributor

abose commented Sep 15, 2015

Tagging @marcelgerber for review.

@marcelgerber
Copy link
Copy Markdown
Contributor

@sprintr There are still 3 occurences of ctx.token.state. You should either switch them over to _getState(), or state that they should not be changed for some reason.

@sprintr
Copy link
Copy Markdown
Contributor Author

sprintr commented Sep 27, 2015

Closing in favor of #11751

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants