Skip to content
This repository was archived by the owner on Sep 6, 2021. It is now read-only.

Fix CSSUtils detection of @import urls#12393

Merged
nethip merged 1 commit intomasterfrom
marcel/cssutils-fix-import-url
May 2, 2016
Merged

Fix CSSUtils detection of @import urls#12393
nethip merged 1 commit intomasterfrom
marcel/cssutils-fix-import-url

Conversation

@marcelgerber
Copy link
Copy Markdown
Contributor

The highlighting of the url keyword changed in codemirror/codemirror5@5e1ca4f and that's why UrlCodeHints didn't show Hints anymore when inside of @import url().

It's kind of my fault fault as I didn't bother running Extension tests when merging that version of CodeMirror.

@nethip
Copy link
Copy Markdown
Contributor

nethip commented May 2, 2016

@marcelgerber Thanks for fixing this.

@redmunds
Copy link
Copy Markdown
Contributor

redmunds commented May 2, 2016

👍

@nethip nethip merged commit 76f3f99 into master May 2, 2016
@nethip
Copy link
Copy Markdown
Contributor

nethip commented May 2, 2016

Thanks @redmunds for reviewing this.

@marcelgerber marcelgerber deleted the marcel/cssutils-fix-import-url branch May 2, 2016 18:34
@marcelgerber
Copy link
Copy Markdown
Contributor Author

Thank you too!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants