This repository was archived by the owner on Sep 6, 2021. It is now read-only.
Resequence autosuggestions for CSS 'list-style'#12738
Merged
petetnt merged 2 commits intoadobe:masterfrom Aug 31, 2016
Merged
Conversation
"none" is surely used far more often than "armenian". Etc.
Contributor
Author
|
Sorry, I hadn't yet submitted a CLA. I've completed and submitted that now. Please review. |
| "letter-spacing": {"values": ["normal", "inherit"]}, | ||
| "line-height": {"values": ["normal", "inherit"]}, | ||
| "list-style": {"values": ["armenian", "circle", "decimal", "decimal-leading-zero", "disc", "georgian", "inherit", "inside", "lower-alpha", "lower-greek", "lower-latin", "lower-roman", "none", "outside", "square", "upper-alpha", "upper-latin", "upper-roman", "url()"]}, | ||
| "list-style": {"values": ["none", "inherit", "initial", "unset", "url", "armenian", "circle", "decimal", "decimal-leading-zero", "disc", "georgian", "inside", "lower-alpha", "lower-greek", "lower-latin", "lower-roman", "outside", "square", "upper-alpha", "upper-latin", "upper-roman"]}, |
Collaborator
There was a problem hiding this comment.
url is missing the braces, url()
Collaborator
|
One small comment, otherwise LGTM |
Contributor
Author
|
Parens added, thx |
Collaborator
|
Thanks for this contribution! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
"none" is surely used far more often than "armenian". Etc.