Disabled context menu items for unsaved files

[mansimarkaur]

Fixes #11763

[ficristo]

Have you checked what other editors do in these cases?
In general you need some jsdocs.
@petetnt @zaggino could someone of you review?

[petetnt]

LGTM sans couple of missing pieces of JSDoc

[petetnt]

Needs JSDoc

[petetnt]

Needs JSDoc

[petetnt]

Thanks for this great PR @mansimarkaur! Tested against latest master and it works great.

Could you add few small pieces of JSDoc for the new methods and maybe simple unit test for the functionality? (it should disable context menu items when not present and it should not disable context menu items when present)

👍

[mansimarkaur]

@petetnt sure, I'll add the required changes.

[mansimarkaur]

@petetnt Could you please help me with the tests? I was thinking of adding tests in the test/Menu-test.js file. Please let me know if it's right?

[petetnt]

@mansimarkaur test/Menu-test.js sounds like a good place.

Any specific things you need help with the tests? The structure should could be something like:

it("it should disable context menu items when file doesn't exist ", function () {
  // runs create a new file
  // opens context menu
  // checks that all the items are disabled
})

it("it should enable context menu items when file does exist ", function () {
  // runs create a new file and saves it
  // opens context menu
  // checks that all the items are enabled
})

For example check DocumentCommandHandlers tests to see how the working set can be manipulated.

[Denisov21]

+1 big idea!

[ficristo]

This needs more work. Closing for now.

[petetnt]

LGTM sans tests, merging this and will open another issue for the tests as per #11763 (comment)

Thanks for this great contribution @mansimarkaur and sorry for taking so long!

PS: did this test totally flake? https://travis-ci.org/adobe/brackets/builds/206719157 CLA checked manually just in case.