This repository was archived by the owner on Sep 6, 2021. It is now read-only.
JSRefactoring Bugs Fix#14455
Merged
boopeshmahendran merged 6 commits intoadobe:masterfrom Aug 2, 2018
niteskum:JSRefactorBugs
Merged
JSRefactoring Bugs Fix#14455boopeshmahendran merged 6 commits intoadobe:masterfrom niteskum:JSRefactorBugs
boopeshmahendran merged 6 commits intoadobe:masterfrom
niteskum:JSRefactorBugs
Conversation
Contributor
|
@niteskum Can you provide a short description of the bugs that you are fixing? |
Collaborator
Author
|
Bug Descriptions:
|
boopeshmahendran
suggested changes
Jun 29, 2018
| * and multi select variable names | ||
| */ | ||
| function extract(scopes, parentStatement, expns, text) { | ||
| function extract(scopes, parentStatement, expns, text, insertPostion) { |
Contributor
There was a problem hiding this comment.
nit: typo insertPosition
| expns[i].start = doc.adjustPosForChange(expns[i].start, varDeclaration.split("\n"), insertStartPos, insertStartPos); | ||
| expns[i].end = doc.adjustPosForChange(expns[i].end, varDeclaration.split("\n"), insertStartPos, insertStartPos); | ||
|
|
||
| /* If there are multiple expressions . then second Expression onward |
Contributor
There was a problem hiding this comment.
Instead of adjusting the position for every replace, can you explore replacing backwards, so that the position need not be adjusted for every change. You can refer (and maybe use) this function
Collaborator
Author
There was a problem hiding this comment.
@boopeshmahendran We need to highlight all the replaced text also so replacing backwards, or "MultipleEdits" function won't help here
Collaborator
Author
|
ping @nethip for review |
boopeshmahendran
suggested changes
Jul 24, 2018
| } | ||
| for(var i = 0; i < refsArray.length; ++i) { | ||
| var element = refsArray[i]; | ||
| if((element.start.line === currentPosition.line || element.end.line === currentPosition.line) |
Contributor
There was a problem hiding this comment.
Maybe you can use refsArray.find.
|
|
||
| //Get Current Selected Property End Index; | ||
| var propertyNodeArray = parentNode.properties; | ||
| for(var i=0; i<propertyNodeArray.length; ++i) { |
Contributor
There was a problem hiding this comment.
Here also maybe you can use find method
| editor.setSelections(refs); | ||
| } else { | ||
| editor.setSelections(refs.filter(function(element) { | ||
| var currentPosition = editor._codeMirror.posFromIndex(refsResp.offset), |
Contributor
There was a problem hiding this comment.
You can use editor.posFromIndex
boopeshmahendran
approved these changes
Jul 26, 2018
boopeshmahendran
approved these changes
Jul 26, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes Fix for JSRefactoring Bug which are reported in dreamweaver
ping @navch @sobisht @boopeshmahendran @raman211 for review